Add "Unite with next" button

This commit is contained in:
Thelonius Kort
2023-05-02 22:09:04 +02:00
parent 4a8f1c3c80
commit 7990b74bf0
8 changed files with 91 additions and 16 deletions

View File

@ -9,13 +9,17 @@
.article span.tunit { .article span.tunit {
@apply hover:bg-gray-300; @apply hover:bg-gray-300;
padding: 5px 0;
margin: -5px 0;
} }
.dark .article span.tunit { .dark .article span.tunit {
@apply hover:bg-gray-700; @apply hover:bg-gray-700;
padding: 5px 0;
margin: -5px 0;
} }
.article span.tunit[current="yes"] { .article span.tunit[current="yes"], .article span.tunit[selected="yes"] {
@apply bg-amber-300 text-stone-700 hover:bg-amber-200 hover:text-red-900; @apply bg-amber-300 text-stone-700 hover:bg-amber-200 hover:text-red-900;
} }

View File

@ -8,14 +8,14 @@ defmodule Outlook.InternalTree.TunitModifications do
name: "unite_with_next", name: "unite_with_next",
fn: &unite_with_next/2, fn: &unite_with_next/2,
label: "Unite with next", label: "Unite with next",
description: "unite translation unit with next" description: "unite selected translation unit with (unselected) next"
}, },
%{ # %{
name: "split_tunit", # name: "split_tunit",
fn: &split_tunit/2, # fn: &split_tunit/2,
label: "Split Translation unit", # label: "Split Translation unit",
description: "split translation unit into two" # description: "split translation unit into two"
} # }
] ]
end end

View File

@ -2,8 +2,8 @@
<.breakpoint_indicator :if={Mix.env == :dev} /> <.breakpoint_indicator :if={Mix.env == :dev} />
<.dark_mode_widget /> <.dark_mode_widget />
</header> </header>
<main class="px-4 py-20 sm:px-6 lg:px-8"> <main class="px-4 sm:px-6 lg:px-8 lg:mx-auto h-screen">
<div class="mx-auto max-w-4xl"> <div class="mx-auto max-w-4xl h-fit">
<.flash kind={:info} title="Success!" flash={@flash} /> <.flash kind={:info} title="Success!" flash={@flash} />
<.flash kind={:error} title="Error!" flash={@flash} /> <.flash kind={:error} title="Error!" flash={@flash} />
<.flash <.flash

View File

@ -9,12 +9,12 @@ defmodule OutlookWeb.TunitEditorComponent do
def tunit_editor(assigns) do def tunit_editor(assigns) do
~H""" ~H"""
<div id="translation-unit-editor" phx-nohook="tunit_editor"> <div id="translation-unit-editor" phx-no-hook="tunit_editor" phx-target={@target}>
<%!-- <div class="h-48 p-2 border border-slate-500 rounded" contenteditable phx-no-change="update_current_tunit"> <%!-- <div class="h-48 p-2 border border-slate-500 rounded" contenteditable phx-no-change="update_current_tunit">
<%= @current_tunit.content |> raw %> <%= @current_tunit.content |> raw %>
</div> --%> </div> --%>
<form phx-change="update_current_tunit" phx-target={@target}> <form phx-change="update_current_tunit" phx-target={@target}>
<textarea id="tunit-editor-content" name="content" class="h-48 rounded border-slate-500 resize-none bg-transparent w-full" <textarea id="tunit-editor-content" name="content" class="h-96 rounded border-slate-500 resize-none bg-transparent w-full"
disabled={!@current_tunit.status}><%= @current_tunit.content %></textarea> disabled={!@current_tunit.status}><%= @current_tunit.content %></textarea>
</form> </form>
<.status_selector target={@target} disabled={!@current_tunit.status} tunit={@current_tunit} /> <.status_selector target={@target} disabled={!@current_tunit.status} tunit={@current_tunit} />
@ -24,7 +24,7 @@ defmodule OutlookWeb.TunitEditorComponent do
defp statuses() do defp statuses() do
[ {:untranslated, "bg-red-800"}, [ {:untranslated, "bg-red-800"},
{:passable, "bg-amber-500"}, {:passable, "bg-amber-500/70"},
{:done, "bg-green-700"} ] {:done, "bg-green-700"} ]
end end

View File

@ -0,0 +1,24 @@
defmodule OutlookWeb.ArticleLive.MenuComponent do
use OutlookWeb, :live_component
attr :entries, :list
# attr :target, :integer, default: 0 # @myself of the Live(View|Component) where the handlers reside
attr :handler, :string
@impl true
def render(assigns) do
~H"""
<div>
<.menu_item :for={entry <- @entries} entry={entry} handler={@handler} />
</div>
"""
end
def menu_item(assigns) do
~H"""
<div title={@entry.description} phx-click={@handler} phx-value-modifier={@entry.name}>
<%= @entry.label %>
</div>
"""
end
end

View File

@ -17,6 +17,7 @@ defmodule OutlookWeb.ArticleLive.New do
|> assign(:raw_html_input, %RawHtmlInput{}) |> assign(:raw_html_input, %RawHtmlInput{})
|> assign(:changeset, Articles.change_raw_html_input(%RawHtmlInput{})) |> assign(:changeset, Articles.change_raw_html_input(%RawHtmlInput{}))
|> assign(:selected_els, []) |> assign(:selected_els, [])
|> assign(:selected_tunits, [])
|> assign(:step, :import_raw_html)} |> assign(:step, :import_raw_html)}
end end
@ -26,6 +27,7 @@ defmodule OutlookWeb.ArticleLive.New do
article = %Article{author_id: author.id} article = %Article{author_id: author.id}
{:noreply, {:noreply,
socket socket
|> assign(:menu_entries, InternalTree.tunit_modifiers()) # REMOVE ME!
|> assign(:author, author) |> assign(:author, author)
|> assign(:article, article)} |> assign(:article, article)}
end end
@ -43,7 +45,9 @@ defmodule OutlookWeb.ArticleLive.New do
{:noreply, {:noreply,
socket socket
|> assign(:raw_internal_tree, |> assign(:raw_internal_tree,
HtmlPreparations.convert_raw_html_input(raw_html_input_params["content"])) HtmlPreparations.convert_raw_html_input(raw_html_input_params["content"])
|> InternalTree.garnish(%{})
)
|> assign(:step, :review_raw_internaltree)} |> assign(:step, :review_raw_internaltree)}
false -> false ->
{:noreply, assign(socket, :changeset, changeset)} {:noreply, assign(socket, :changeset, changeset)}
@ -54,10 +58,42 @@ defmodule OutlookWeb.ArticleLive.New do
def handle_event("approve_raw_internaltree", _, socket) do def handle_event("approve_raw_internaltree", _, socket) do
socket = socket socket = socket
|> assign(:raw_internal_tree, |> assign(:raw_internal_tree,
InternalTree.partition_text(socket.assigns.raw_internal_tree)) InternalTree.partition_text(socket.assigns.raw_internal_tree)
|> InternalTree.garnish(%{tunits: %{class: :tunit}})
|> InternalTree.add_phx_click_event(
nodes: :tunits,
click: "toggle_selected_tunit")
)
|> assign(:menu_entries, InternalTree.tunit_modifiers())
{:noreply, socket |> assign(:step, :review_translation_units)} {:noreply, socket |> assign(:step, :review_translation_units)}
end end
@impl true
def handle_event("toggle_selected_tunit", %{"nid" => tunit_id}, socket) do
{:noreply, toggle_selected_tunit(socket, tunit_id)}
end
defp toggle_selected_tunit(socket, tunit_id) do
before = socket.assigns.selected_tunits
selected_tunits = case Enum.member?(before, tunit_id) do
false -> List.insert_at(before, -1, tunit_id)
true -> List.delete(before, tunit_id)
end
fun = fn n -> n.nid in selected_tunits && "yes" || "no" end
socket
|> assign(:raw_internal_tree, InternalTree.garnish(socket.assigns.raw_internal_tree, %{tunits: %{selected: fun}}))
|> assign(:selected_tunits, selected_tunits)
end
@impl true
def handle_event("modify_tunits", %{"modifier" => modifier}, socket) do
{:noreply,
socket
|> assign(:raw_internal_tree,
InternalTree.modify_tunits(socket.assigns.raw_internal_tree, modifier, socket.assigns.selected_tunits)
)}
end
@impl true @impl true
def handle_event("approve_translation_units", _, socket) do def handle_event("approve_translation_units", _, socket) do
{:noreply, socket |> assign(:step, :final_form)} {:noreply, socket |> assign(:step, :final_form)}

View File

@ -4,7 +4,7 @@
<.import_raw_html :if={@step == :import_raw_html} changeset={@changeset} /> <.import_raw_html :if={@step == :import_raw_html} changeset={@changeset} />
<.review_raw_internaltree :if={@step == :review_raw_internaltree} raw_internal_tree={@raw_internal_tree} /> <.review_raw_internaltree :if={@step == :review_raw_internaltree} raw_internal_tree={@raw_internal_tree} />
<.review_translation_units :if={@step == :review_translation_units} /> <.review_translation_units :if={@step == :review_translation_units} raw_internal_tree={@raw_internal_tree} menu_entries={@menu_entries} />
<.live_component <.live_component
:if={@step == :final_form} :if={@step == :final_form}
module={OutlookWeb.ArticleLive.FormComponent} module={OutlookWeb.ArticleLive.FormComponent}

View File

@ -44,6 +44,17 @@ defmodule OutlookWeb.ArticleLive.NewComponents do
def review_translation_units(assigns) do def review_translation_units(assigns) do
~H""" ~H"""
<div>Review Translation Units</div> <div>Review Translation Units</div>
<div class="flex gap-4">
<div id="html-tree" class="w-96 overflow-auto whitespace-nowrap">
<.render_tree tree={@raw_internal_tree} ></.render_tree>
</div>
<div id="partition-preview" class="article show-boundary overflow-auto h-full">
<.render_doc tree={@raw_internal_tree} ></.render_doc>
</div>
<div>
<.live_component module={OutlookWeb.ArticleLive.MenuComponent} entries={@menu_entries} handler="modify_tunits" id={:review_tunits} />
</div>
</div>
<.button phx-click="approve_translation_units">Continue</.button> <.button phx-click="approve_translation_units">Continue</.button>
""" """
end end