thelonius/phoenix-ausblick
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Refactor query functions

Browse Source
This commit is contained in:
Thelonius Kort
2023-03-02 23:17:21 +01:00
parent cbea9450e4
commit b20bbb232c
1 changed files with 6 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
lib/outlook/public.ex
View File

@ -8,7 +8,7 @@ implement to_param protocol (no more needed for Outlook.Translations.Translation
alias Outlook.Translations.Translation
alias Outlook.Articles.Article
alias Outlook.Authors.Author
alias Outlook.Public.Artikel
alias Outlook.Public.{Artikel,Autor}
import Ecto.Query, warn: false
alias Outlook.Repo
@ -17,19 +17,17 @@ implement to_param protocol (no more needed for Outlook.Translations.Translation
q = from t in Translation,
join: a in Article, on: t.article_id == a.id,
join: au in Author, on: a.author_id == au.id,
select: [
select: %Artikel{
title: t.title,
date: t.date,
teaser: t.teaser,
id: t.id,
date_org: a.date,
autor_name: au.name,
],
},
where: t.public == true and t.language == ^language,
order_by: [desc: t.date]
Repo.all(q)
# |> Enum.map(fn rec -> Enum.into(rec, %{}) end)
|> Enum.map(fn map -> struct(Artikel, map) end)
end
def get_artikel!(artikel) when is_struct(artikel), do: get_artikel!(artikel.id)
@ -37,7 +35,7 @@ implement to_param protocol (no more needed for Outlook.Translations.Translation
q = from t in Translation,
join: a in Article, on: t.article_id == a.id,
join: au in Author, on: a.author_id == au.id,
select: [
select: %Artikel{
title: t.title,
date: t.date,
public_content: t.public_content,
@ -46,11 +44,11 @@ implement to_param protocol (no more needed for Outlook.Translations.Translation
date_org: a.date,
autor_name: au.name,
autor_id: au.id
],
},
where: t.id == ^id and t.public == true
case Repo.one(q) do
nil -> {:error, "Artikel does not exist, or isn't public."}
artikel -> {:ok, struct(Artikel, artikel)}
artikel -> {:ok, artikel}
end
end